What

Implemented GenLayer JS in the Studio frontend
Added possibility to return null on get_transaction_by_hash endpoint (was breaking when a server-side tx didn't exist)

Why

To get closer to the actual final implementation and use the correct api's
To fix a bug

Testing done

tested the new feature
tested the bug fix

Decisions made

Removed some functionality that is now covered by the GenLayer JS library (nonces, useWallet hook...)

Checks

[x] I have tested this code
[x] I have reviewed my own PR
[x] I have created an issue for this PR
[x] I have set a descriptive PR title compliant with conventional commits

User facing release notes

Implemented the official GenLayer JS library to handle accounts and transactions in the Studio

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 30.08850% with 79 lines in your changes missing coverage. Please review.

Project coverage is 18.34%. Comparing base (6f07d9e) to head (5c1d938).

Files with missing lines	Patch %	Lines
frontend/src/hooks/useContractQueries.ts	10.71%	25 Missing :warning:
frontend/src/hooks/useGenlayer.ts	26.47%	25 Missing :warning:
frontend/src/hooks/useShortAddress.ts	5.55%	17 Missing :warning:
frontend/src/components/Simulator/AccountItem.vue	0.00%	4 Missing :warning:
frontend/src/components/Simulator/ContractInfo.vue	0.00%	3 Missing :warning:
frontend/src/hooks/useSetupStores.ts	25.00%	3 Missing :warning:
...rontend/src/components/Simulator/AccountSelect.vue	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #600 +/- ## ========================================== - Coverage 19.06% 18.34% -0.73% ========================================== Files 127 127 Lines 9759 9698 -61 Branches 300 290 -10 ========================================== - Hits 1861 1779 -82 - Misses 7813 7834 +21 Partials 85 85 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

denishacquin commented 1 week ago

@cristiam86 any hint on how to use leaderonly functionality with GenLayer JS?

cristiam86 commented 1 week ago

@cristiam86 any hint on how to use leaderonly functionality with GenLayer JS?

sure, to use it in GenLayerJS, it should be implemented there :D https://github.com/yeagerai/genlayer-js/issues/24

denishacquin commented 3 days ago

Regarding the leaderOnly feature, I've been trying to implement it in genlayer-js, without success until now.

If I dare ask, how important is that feature? Won't it have to be removed once we hook the studio to the real chain? @cristiam86

cristiam86 commented 3 days ago

Regarding the leaderOnly feature, I've been trying to implement it in genlayer-js, without success until now.

If I dare ask, how important is that feature? Won't it have to be removed once we hook the studio to the real chain? @cristiam86

Let's take a look together whenever you can :) This is going to be available permanently in the localnet. Of course, it won't be available in the testnet or mainnet. In Ethereum and other L1s, there are some methods that can be only used in the localnet and they make it easy to force situations or to speed up the development.

denishacquin commented 2 days ago

Note that if we want to support the leaderOnly param in this PR, we need to merge the feature in genlayer-js then update the dependency here. @cristiam86