Refactor RPC endpoints - Githubissues

yeagerai / genlayer-studio

MIT License

17 stars 8 forks source link

Closed cristiam86 closed 2 months ago

cristiam86 commented 2 months ago

We need to do some refactor on the following endpoints to match the Ethereum specs: (backend/protocol_rpc/endpoints.py)

create_account: remove it and comment its usage on every place
send_transaction: remove it and comment its usage on every place
get_contract_state: rename it to call and change the parameters to match the Ethereum specification here: https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_call. Also, note that the frontend serialization (and maybe the signing should be also considered)

denishacquin commented 2 months ago

should the fund_accountalso be removed?

cristiam86 commented 2 months ago

should the fund_accountalso be removed?

nop, that one we will use it.

denishacquin commented 2 months ago

Which covers the removal of the two first endpoints as well as the renaming of the third.

However, I would need us to chat for the spec matching / frontend serialization stuff to gain some clarity on that @cristiam86

github-actions[bot] commented 2 months ago

:tada: This issue has been resolved in version 0.6.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: