yeahdongcn / RSBarcodes_Swift

1D and 2D barcodes reader and generators for iOS 8 with delightful controls. Now Swift.
MIT License
708 stars 185 forks source link

Fixed Swift 4.2 warnings and updated deployment target to 10.3. #120

Closed cafedeichi closed 6 years ago

zeusent commented 6 years ago

Is someone looking at this? I would appreciate if a new pod version would be rolled out

zeusent commented 6 years ago

Hm... I just tried using this branch but I see that the minimum iOS version was increased to 10.3. Any good reason for that @cafedeichi?

yeahdongcn commented 6 years ago

Is someone looking at this? I would appreciate if a new pod version would be rolled out

Will handle this today

yeahdongcn commented 6 years ago

Thank you for the PRs @cafedeichi ! But I merged the PRs from @zeusent , since your PRs are similar. I'm now pushing the new podspec to Cocoapods, please use 4.2.0 to consume this pod. Thanks again.

cafedeichi commented 6 years ago

@zeusent

Hm... I just tried using this branch but I see that the minimum iOS version was increased to 10.3. Any good reason for that @cafedeichi?

Thx a lot for your nice question. As long as i see the current usage percentage of iOS, I thought it would be meaningless to support the older versions such iOS8/9. I'd like to know why the support for the OS, which is obsolete and insecure, is still necessary if you think so to the contrary.