fixing a few tests that were making sure that we continue following the wrong behaviour. If you SET a null/undefined, that IS supposed to give you an error. If you SET an object, that IS supposed to give you an error. Tested experimentally with redis to make sure of that.
introducing a more reliable method for parsing arguments.
In the consecutive PRs I'm planning to eventually completely replace the old way of argument parsing and introduce the ArgumentParser into all commands.
The PR contains the following changes:
updating the engine version to 6, as this is the version currently supported in the actual
redismodule: https://github.com/NodeRedis/node-redis/blob/master/package.json#L46Since using Node 6, I took into use features like
let,const,classand arrow functionsMaking the optional parameters of SCAN and SSCAN actually optional. Before it required the MATCH parameter to always be there.
Fixing, related issue that was already reported a long ago: https://github.com/yeahoffline/redis-mock/issues/130
Confirmed that the reporter was right and fixed: https://github.com/yeahoffline/redis-mock/issues/129 which was also quite closely related
fixing a few tests that were making sure that we continue following the wrong behaviour. If you SET a null/undefined, that IS supposed to give you an error. If you SET an object, that IS supposed to give you an error. Tested experimentally with
redisto make sure of that.introducing a more reliable method for parsing arguments.
In the consecutive PRs I'm planning to eventually completely replace the old way of argument parsing and introduce the
ArgumentParserinto all commands.