yearn / ape-tax

https://ape.tax
46 stars 34 forks source link

Separate chain config details into `wagmiChains.ts` #223

Closed 0xMirim closed 1 year ago

0xMirim commented 1 year ago

What is your proposal 🚀

Currently we have a wagmiConfig.ts file (utils/wagmiConfig.ts) the file imports chain details then passes them to the configureChains() function which tells our app which chains ape tax should support.

We should follow the good example set by the big brains at SmolDapp! This can be done by separating out all the specific chain details objects into their own file probably called wagmiChains.ts then exporting them similar to what is shown here:

https://github.com/SmolDapp/smoldapp/blob/main/utils/wagmiChains.ts

What does this solve ? 🛠

Increases ease of reading and understanding the config file by moving chain specific details to a new file that only contains these chain specific details.

More 🔎

Make this adjustment on feat/v3-new branch please

There will be no visual change to the app since this is just a change to overall organization / structure.

0xMirim commented 1 year ago

Completed