pandadefi
commented
2 years ago You are correct, this is one of the drawbacks of the system
If we were to distribute rewards when they are queued, we would need a snapshot of all user's balances to distribute accordingly which isn't possible.
If you claim on a regular basis and relock your overall power increases and that's the best strategy to get the best yield.
A second way to do that would be to keep a balance per user and a total balance based on the sum of the balances snapshotted but doing so will make it possible for someone to claim after the expiration of his lock. A solution to that is incentivising others to claim to trigger the ve balance update with some penalty mechanism (ex: 0.25% of the rewards are distributed to the one claiming for every week after a lock expired).
On this poc the balance is updated on claim, deposits, withdraw and new lock.
A third way to do this could be to take an average of the user power and total over a period of time but I am not sure that could work.
If you have ideas on how to solve or mitigate the issue, please share.
chudnov
Since the penalty of early withdrawal is distributed to the existing yfi stakers, shouldn't the distribution also depends on a yfi lockers veYFI weights at the time which a separate individual did early withdraw (and therefore lost some yfi to veyfi rewards)? The current implementation makes those who are periodically calling deposit/withdraw earn more rewards from penalties than those who don't. This is because, by the time someone claims penalties YFI, their veYFI balance could already be 0 as it decays.
Line 67