yearn / veYFI

Voting YFI
75 stars 38 forks source link

Fix tests #174

Closed pandadefi closed 2 years ago

pandadefi commented 2 years ago

Description

One test left to fix, would really benefit from tracing to debug. This only runs on hardhat

Fixes # (issue)

Checklist

banteg commented 2 years ago

can you report the issues which prevent running on foundry to ape-foundry and foundry?

pandadefi commented 2 years ago

It's possible that this has been solved but a new version of ape-foundry is required. https://github.com/ApeWorX/ape-foundry/commit/345bced85d7f052d5cda36b1d0b3792ddeb94ba0

pandadefi commented 2 years ago

Got one failing conftest that prevents one test to run:

AttributeError: 'ProjectManager' object has no attribute 'ZapClaim'

Not sure what's going on with ape here @fubuloubu

fubuloubu commented 2 years ago

Got one failing conftest that prevents one test to run:

AttributeError: 'ProjectManager' object has no attribute 'ZapClaim'

Not sure what's going on with ape here @fubuloubu

Hmm, that is pretty bizarre. Does it work locally and only fails in CI? If it fails locally, can you do ape compile -f and then it works? Think it might be something to do with build caching logic

fubuloubu commented 2 years ago

It's possible that this has been solved but a new version of ape-foundry is required. ApeWorX/ape-foundry@345bced

Can release ape-foundry once https://github.com/ApeWorX/ape-foundry/pull/5 is merged

pandadefi commented 2 years ago

Hmm, that is pretty bizarre. Does it work locally and only fails in CI? If it fails locally, can you do ape compile -f and then it works? Think it might be something to do with build caching logic

The issue is also on local even using with ape compile -f done before.

What is confusing is it's compiling the file when running ape compile -f