Bug: Graph legend square not square

yearn / yPartners

Partners website

https://partners.yearn.farm

GNU General Public License v3.0

6 stars 5 forks source link

Bug: Graph legend square not square #146

Closed Majorfi closed 1 year ago

Majorfi commented 1 year ago

What happened 🆘

Minor UI issue on the Aggregate Wrapper Balance (USD) graph, the Square for the Aggregate Wrapper Balance legend is not a square. Should be square.

To Reproduce 🔂

Steps to reproduce the behavior: Visit a partner page and check the rectangle.

More 🔎

Browser: All
Screen size: 13'

Screenshots

0xMirim commented 1 year ago

Good eye! Technically I implemented it this way because this is how it's specified in the Figma design. I will consult Lord Kox to see how important the rectangle is.

0xMirim commented 1 year ago

Evan responded saying that the idea was to have the Aggregate Wrapper Balance legend item be thin to represent the thin bars on the chart. I agree for the most part. Though the implementation can probably be improved.

I'm going to close this for now but I will say that if we have issues with this "thin legend item" in the future I will immediately remove the styles that cause the effect and we can just have all legend items be square.