This PR resolves an error that caused a small subset of dashboards to crash during data visualization. The issue itself was related to how I was back-filling missing data (which is require to avoid other visual issues).
Basically the calculation for how many days of empty data needed to be back-filled could in some cases result in a decimal (ex: 28.1234) number causing an extra incorrect day to be added to the back-filled data, leading to out of range errors during visualization.
This error is resolve by using Math.floor in DashboardTabsWrapper.tsx, on lines 194 and 271
Extra:
Improved UI when stacked charts have no data to display (Phuture is an example). We show show chart title to give user context for what chart lacks data currently.
Expanded All time data window to 45 form 40 (these are current limitations imposed by exporter until it is made bi-directional)
Description
This PR resolves an error that caused a small subset of dashboards to crash during data visualization. The issue itself was related to how I was back-filling missing data (which is require to avoid other visual issues).
Basically the calculation for how many days of empty data needed to be back-filled could in some cases result in a decimal (ex: 28.1234) number causing an extra incorrect day to be added to the back-filled data, leading to out of range errors during visualization.
This error is resolve by using Math.floor in DashboardTabsWrapper.tsx, on lines 194 and 271
Extra:
Extra from Itzabelli (I reviewed / approved):
Related Issue
N/A
Motivation and Context
Resolve dashboard crash
How Has This Been Tested?
I manually entered all dashboards to verify the overview tabs loaded properly
Resources
Following is for the improvements to the no data UI on sacked charts
Before:
After: