yearn / yPartners

Partners website
https://partners.yearn.farm
GNU General Public License v3.0
6 stars 5 forks source link

fix: Prevent crash when data availability differs across chains #171

Closed 0xMirim closed 1 year ago

0xMirim commented 1 year ago

Description

Partners with vaults on both ETH and FTM experienced crashes due to incomplete data for ETH being available. These changes add conditions or filters to prevent these errors from crashing the dashboards.

crashes observed for: Ledger, Alchemix, and Abracadabra. Spool also had a crash for a different but related reason that these changes also fix.

Extra: Fixed separate crash when viewing the tooltip for the last item in Aggregate Wrapper Balance chart. This error was also caused by incomplete data for partners with vaults on both ETH and FTM. Crashes observed for: Abracadabra, Alchemix, Tempus

Motivation and Context

Dashboards crashes have been observed for a subset of partners after recent issues with data availability for our Ethereum node. These changes address usability issues for these partners by adding conditions to avoiding crashes.

How Has This Been Tested?

Manually entering all dashboards to ensure crashes on loading of Overview tab no longer take place for any partners.

Resources

N/A

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ypartners ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2023 8:13am