search

yearn / ySync

sync.yearn.farm
GNU General Public License v3.0
3 stars 10 forks source link

fix: Filter logic for vault entities #107

Closed karelianpie closed 1 year ago

karelianpie commented 1 year ago

Description

The hasAnomalies logic should not have the logic from the filters, otherwise it's not possible to filter correctly.

Removed the custom filter logic for icons and price from the hasAnomalies constant, and checked for this anomalies and the price, icon and translations separately. Thus, if it hasn't "other anomalies" it might still have the new filterable anomalies (price, icon and translations).

Related Issue

Fixes https://github.com/yearn/ySync/issues/94, fixes https://github.com/yearn/ySync/issues/103

Motivation and Context

Fix the way filtering is working

How Has This Been Tested?

Tested locally

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ysync ✅ Ready (Inspect) Visit Preview Jul 30, 2023 11:13am
karelianpie commented 1 year ago

@Majorfi please double check that this logic is correct! 🙇