yearn / ydaemon

Next gen API for Yearn
https://ydaemon.yearn.farm/
29 stars 31 forks source link

Bug: Group "Convex Factory" (Ethereum) Is Not Display in Risk Framework #326

Closed rareweasel closed 1 year ago

rareweasel commented 1 year ago

Overview

The Convex Factory group is not display in Seafood/Yearn Watch.

Reproduce

Thoughts

No response

Majorfi commented 1 year ago

Strategy group is correctly attributed: https://ydaemon.yearn.fi/1/vault/0x77e829FFF18C14AD9bb88963acB0010A0506de88?strategiesDetails=withDetails&strategiesCondition=all

Watch and seafood may not use the strategiesCondition=all flag, which also display strategies with low TVL/debt. If you check this strategie: 0xaC90Cc48283304E5B2256B83EAd5FAC9e0Ff87A2, which is in the group for vault 0x77e829FFF18C14AD9bb88963acB0010A0506de88, we have:

"totalDebt": "0",
"totalLoss": "0",
"totalGain": "0",
"debtLimit": 0,

By default, debtLimit === 0 or debtRatio === 0 are ignored.