Bug: Incorrect api version for v3 vaults

yearn / ydaemon

Next gen API for Yearn

https://ydaemon.yearn.farm/

29 stars 31 forks source link

Bug: Incorrect api version for v3 vaults #362

Closed pata-eth closed 5 months ago

pata-eth commented 5 months ago

Overview

pata, [Mar 21, 2024 at 1:42:45 PM]: hi mothers, the api versions are wrong https://etherscan.io/address/0x028eC7330ff87667b6dfb0D94b954c820195336c#readContract is 3.0.2 buy daemon shows 3.0.0

need a fix to properly implement v3 in the solver

cc @Majorfi

same with this one 0xc56413869c6CDf96496f2b1eF801fEDBdFA7dDB0

Reproduce

Thoughts

No response

Schlagonia commented 5 months ago

FYI: it seems to be all 3.0.2 vaults and strategies, at least on mainnet not just these two

Majorfi commented 5 months ago

Reason: unlike the v2 vaults, the apiVersion is not available in the v3 event Why using 3.0.0: because in term of yDaemon, it was not that of an issue to have it But: bad

Fixed