yearn / yearn-devdocs

yearn documentation
https://docs.yearn.fi
80 stars 70 forks source link

Update using-yearn.md #424

Closed theminion0987 closed 3 months ago

theminion0987 commented 5 months ago

Updated page with walkthrough screenshots V3 vault. Removed Zapping feature as no longer featured on V3 or V2 vaults.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yearn-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 11:33am
rossgalloway commented 4 months ago

Hey @theminion0987, I'm going to be taking over docs management for Marco. I want to have some more complete conversations with you and the rest of ySupport about what you want to see from the docs repo, but I wanted to throw out some thoughts I had as I have been working through ideas and saw your pull request here.

Since the V2 vaults still exist, it seems to me that we would want to have walk-throughs for both the V2 and the V3 vaults. They could be very similar, where we keep what you have here as the V3 walk-through, and then also keep the old V2 version but change the first 2 images to show the new network selection flow and remove the zapping part if that isn't being used anymore. I would also move these 2 walk-throughs into the Guides section.

I'm happy to do the heavy lifting on these changes if you (and the ySupport team) think they are a good idea. Looking forward to hearing your thoughts.

theminion0987 commented 4 months ago

Hey, glad to see you managing the docs. Please let me know if I can support in any way. Sounds all good regarding the V2/V3 doc changes - I'll speak through the ySupport team if there is anything they would like to see that would make things easier and let you know. Thanks for reaching out! (missed this notification so apologies for the slow response)

On Tue, May 21, 2024 at 10:18 PM rossgalloway @.***> wrote:

Hey @theminion0987 https://github.com/theminion0987, I'm going to be taking over docs management for Marco. I want to have some more complete conversations with you and the rest of ySupport about what you want to see from the docs repo, but I wanted to throw out some thoughts I had as I have been working through ideas and saw your pull request here.

Since the V2 vaults still exist, it seems to me that we would want to have walk-throughs for both the V2 and the V3 vaults. They could be very similar, where we keep what you have here as the V3 walk-through, and then also keep the old V2 version but change the first 2 images to show the new network selection flow and remove the zapping part if that isn't being used anymore. I would also move these 2 walk-throughs into the Guides section.

I'm happy to do the heavy lifting on these changes if you (and the ySupport team) think they are a good idea. Looking forward to hearing your thoughts.

— Reply to this email directly, view it on GitHub https://github.com/yearn/yearn-devdocs/pull/424#issuecomment-2123458999, or unsubscribe https://github.com/notifications/unsubscribe-auth/BH26N4RWG23JJLL2US6NJBDZDO2ZLAVCNFSM6AAAAABGZBIAZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRTGQ2TQOJZHE . You are receiving this because you were mentioned.Message ID: @.***>

MarcoWorms commented 3 months ago

sorry I was reviewing this and accidentally approved (bc no issues found in changes made), but I just saw that ross was talking to you about it here so I will wait for confirmation before merging this!

MarcoWorms commented 3 months ago

incuded in #437