yearn / yearn-finance-v3

Yearn Finance Web App v3
https://yearn.finance
124 stars 140 forks source link

fix: portfolio wallet deposit modal vault select #628

Closed edwinzhng closed 2 years ago

edwinzhng commented 2 years ago

Description

Related Issue

Fixes #626

Motivation and Context

Now users can select a vault to zap into again instead of just the default

How Has This Been Tested?

Manually tested on portfolio wallet page with different tokens. Also tested the vault page and confirmed that functionality is still the same there (can change token but cannot change vault to deposit into).

Screenshots (if appropriate):

Screen Shot 2022-05-03 at 5 11 08 PM

Screen Shot 2022-05-03 at 5 13 19 PM

aws-amplify-us-east-1[bot] commented 2 years ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-628.d27dgpz01hmbvx.amplifyapp.com

FoxTheSin commented 2 years ago

eth sim passed, looks good so far image

FoxTheSin commented 2 years ago

possibly need to apply a different fix before this? image

xgambitox commented 2 years ago

possibly need to apply a different fix before this? image

Yeah, this was an issue with the allowlist and not related to this fix.

Good one @edwinzhng :)