fix: height and width for vault details icon and nested h1 elements - Githubissues

yearn / yearn-finance-v3

Yearn Finance Web App v3

https://yearn.finance

124 stars 140 forks source link

fix: height and width for vault details icon and nested h1 elements #655

Closed edwinzhng closed 2 years ago

edwinzhng commented 2 years ago

Description

Width/height weren't applying properly to the vault details icon due to the CSS being overridden by max-width: 100% on img elements - I didn't want to override this globally so instead I set min-width and min-height for the image
Cleaned up a TODO and moved px values over to rem
The navbar was also giving a console error because we had h1 elements nested inside each other, so I fixed it

Related Issue

Fixes #654

Motivation and Context

The dev console was throwing an error about nested H1 elements in the Navbar which is now fixed
The icon for the vault details page now shows up correctly

How Has This Been Tested?

Manual testing

Screenshots (if appropriate):

Large icon now shows up under Overview:

Screen Shot 2022-05-11 at 10 43 50 AM

aws-amplify-us-east-1[bot] commented 2 years ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-655.d27dgpz01hmbvx.amplifyapp.com