search

yearn / yearn-finance-v3

Yearn Finance Web App v3
https://yearn.finance
124 stars 140 forks source link

fix: susd modal not displaying #683

Open FoxTheSin opened 2 years ago

FoxTheSin commented 2 years ago

Describe the bug when sUSD in wallet (and potentially other tokens?) the deposit modal (TxContainer) doesn't appear when clicking deposit button.

To Reproduce Steps to reproduce the behavior:

  1. Go to portfolio with susd
  2. click on deposit next to susd token
  3. Scroll down to '....'
  4. See error

Expected behavior The deposit modal should appear and token should be zappable into vault (or, if unzapable, an error message should pop up in modal that states that token can't be zap'd)

Screenshots normal image

susd image

Environment Information

Additional context susd contract: 0x57Ab1ec28D129707052df4dF418D58a2D46d5f51

xgambitox commented 2 years ago

Yeah. First step is to determine if sUSD is supported by zapper for zapping in into vaults. If its not supported, then we should not be displaying it at all in the portfolio view, since we want to display only actionable tokens within yearn app.

xgambitox commented 2 years ago

Maybe there was an sUSD vault that is now deprecated, and that is why sUSD is treated as a valid underlying token for direct deposits?