search

yearn / yearn-finance-v3

Yearn Finance Web App v3
https://yearn.finance
123 stars 138 forks source link

feat: zappable tokens shortcut [WEB-1524] #694

Closed turtlemoji closed 2 years ago

turtlemoji commented 2 years ago

Description

Should add, in vault details and modal, a quick action to change between tokens with available amounts

image

How Has This Been Tested?

Local env, desktop, mobile down to 375px.

Screenshots (if appropriate):

Result: image

Mobile: image

linear[bot] commented 2 years ago
WEB-1524 You can ZAP - enhancements

User can see and select their top available zappable tokens without having to click the ZAP icon to open overlay Display one row of tokens - as per design sorted by highest holdings to lowest holdings excluding non-zappable tokens Set a max-width on token button, with overflow text ellipsis Display max 6-7 token buttons [image.png](https://uploads.linear.app/71c58dc2-224e-40a9-b4c0-5ae717f1e931/cddbe853-bd39-43d8-8575-ad39e407e7c9/01723983-adb2-4df4-9fe9-b64a4d20c3ab) **TO MAKE THIS WORK this should be done first:** [https://linear.app/yearn/issue/WEB-1525/cards-sizes-on-vault-detailed-page](https://linear.app/yearn/issue/WEB-1525/cards-sizes-on-vault-detailed-page) Or user can click "View all" to open overlay to view all zappable tokens

aws-amplify-us-east-1[bot] commented 2 years ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-694.d27dgpz01hmbvx.amplifyapp.com

xgambitox commented 2 years ago

We should look into refactor this component into its own for composability. Might be good for a refactor after this PR.

turtlemoji commented 2 years ago

We should look into refactor this component into its own for composability. Might be good for a refactor after this PR.

agree