yearn / yearn-finance-v3

Yearn Finance Web App v3
https://yearn.finance
123 stars 138 forks source link

Unstoppable Domains Login Integration(checking for actuality of task) #740

Closed bogdanuch41 closed 2 years ago

bogdanuch41 commented 2 years ago

Description

For now It's just a test request to see if this integration is needed. Please let us know if this task is available to be implemented in yearn or there is no usage for it in your app. If you would like to integrate it, then we can do it for you.

Related Issue

https://github.com/yearn/yearn-finance-v3/issues/541

Motivation and Context

Login with Unstoppable allows 300k+ users to log in to dapps with their human readable NFT domain (like brian.crypto) username as opposed to a cryptocurrency address.

aws-amplify-us-east-1[bot] commented 2 years ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-740.d27dgpz01hmbvx.amplifyapp.com

xgambitox commented 2 years ago

Hey there @bogdanuch41 , we want to first upgrade to latest v2 version of Blocknative's web3-onboard lib. It just has not been our priority for now, but we will move forward with it soon. Then we can continue adding other wallet integrations from there. For now, we can put this one on hold.

bogdanuch41 commented 2 years ago

Can I help you with moving to version v2 of web3-onboard lib? Or you already have somebody to do this task?

xgambitox commented 2 years ago

Can I help you with moving to version v2 of web3-onboard lib? Or you already have somebody to do this task?

Sure, give it a shot if you can. Post the issue and assign it to you. We should support the wallets we currently have and test the most popular ones to make sure we dont have any regression.

Will close this PR for now.