search

yearn / yearn-finance-v3

Yearn Finance Web App v3
https://yearn.finance
123 stars 138 forks source link

feat: Implement `SimpleTransaction` component #741

Closed karelianpie closed 2 years ago

karelianpie commented 2 years ago

Description

Implement the Stake veYFI modal

Motivation and Context

Current modal is using the old yearn style

Screenshots (if appropriate):

yearn_finance
xgambitox commented 2 years ago

Now that the UI is component is there, we should look into replacing the usage of the Transaction component in Gauges/StakeTx and Gauges/Unstake for this one (We should better rename this one to a more generic, like SimpleTransaction, so that it can be reused across other places). Some of the props used in the transaction component are no longer needed since this SimpleTransaction component doesnt render nothing about the targetToken.

Since we dont have specs for error or success state for the transaction, lets reuse the one used in Transaction component.

karelianpie commented 2 years ago

Now that the UI is component is there, we should look into replacing the usage of the Transaction component in Gauges/StakeTx and Gauges/Unstake for this one (We should better rename this one to a more generic, like SimpleTransaction, so that it can be reused across other places). Some of the props used in the transaction component are no longer needed since this SimpleTransaction component doesnt render nothing about the targetToken.

Since we dont have specs for error or success state for the transaction, lets reuse the one used in Transaction component.

Would you be happy doing this in a different PR?