fix: show approve button on withdraw for zapper tokens

yearn / yearn-finance

🏦 yearn v2 web interface

https://yearn.finance

MIT License

169 stars 111 forks source link

fix: show approve button on withdraw for zapper tokens #353

Closed patcito closed 3 years ago

vercel[bot] commented 3 years ago

@patcito is attempting to deploy a commit to the Yearn Finance Team on Vercel.

A member of the Team first needs to authorize it.

yearn-integrations commented 3 years ago

Important changes detected (payment related code)

Found keyword web3 in files app/components/VaultControls/index.js (+ const [web3Account, setWeb3Account] = useState(account);), app/components/VaultControls/index.js (+ if (account !== web3Account && account) {), app/components/VaultControls/index.js (+ web3Account &&), app/components/VaultControls/index.js (+${vaultContract.address.toLowerCase()}&ownerAddress=${web3Account},), app/components/VaultControls/index.js (+ web3Account &&), app/components/VaultControls/index.js (+${vaultContract.address.toLowerCase()}&ownerAddress=${web3Account},)

yearn-integrations commented 3 years ago

Important changes detected (payment related code)

Found constant ZAPPER_APIKEY in files app/components/VaultControls/index.js (+const { ZAPPER_APIKEY } = process.env;), app/components/VaultControls/index.js (+api_key=${ZAPPER_APIKEY}+), app/components/VaultControls/index.js (+api_key=${ZAPPER_APIKEY}+)
Found keyword web3 in files app/components/VaultControls/index.js (+ const [web3Account, setWeb3Account] = useState(account);), app/components/VaultControls/index.js (+ if (account !== web3Account && account) {), app/components/VaultControls/index.js (+ web3Account &&), app/components/VaultControls/index.js (+${vaultContract.address.toLowerCase()}&ownerAddress=${web3Account},), app/components/VaultControls/index.js (+ web3Account &&), app/components/VaultControls/index.js (+${vaultContract.address.toLowerCase()}&ownerAddress=${web3Account},)

xgambitox commented 3 years ago

@patcito not working for me. Trying with an approved vault to zap out, but the button label still is 'Approve', even though when I click it, it does popup the wallet transaction for the zap out.

yearn-integrations commented 3 years ago

Important changes detected (payment related code)

Found constant ZAPPER_APIKEY in files app/components/VaultControls/index.js (+const { ZAPPER_APIKEY } = process.env;), app/components/VaultControls/index.js (+api_key=${ZAPPER_APIKEY}&sellTokenAddress=+), app/components/VaultControls/index.js (+api_key=${ZAPPER_APIKEY}&sellTokenAddress=+)
Found keyword web3 in files app/components/VaultControls/index.js (+ const [web3Account, setWeb3Account] = useState(account);), app/components/VaultControls/index.js (+ if (account !== web3Account && account) {), app/components/VaultControls/index.js (+ web3Account &&), app/components/VaultControls/index.js (+${vaultContract.address.toLowerCase()}&ownerAddress=${web3Account},), app/components/VaultControls/index.js (+ web3Account &&), app/components/VaultControls/index.js (+${vaultContract.address.toLowerCase()}&ownerAddress=${web3Account},)

patcito commented 3 years ago

@patcito not working for me. Trying with an approved vault to zap out, but the button label still is 'Approve', even though when I click it, it does popup the wallet transaction for the zap out.

my bad, deleted a param in url fetching approval state on zapper. Should work now.