feat: update withdraw button on zapout approval using saga

[patcito]

related https://linear.app/yearn/issue/WEB-398/approve-button-does-not-change-after-an-approval-succeed-when-zapping

[vercel[bot]]

@patcito is attempting to deploy a commit to the Yearn Finance Team on Vercel.

A member of the Team first needs to authorize it.

[yearn-integrations]

Important changes detected (payment related code)

• Found constant DEFAULT_SLIPPAGE in files app/components/VaultControls/index.js (- slippagePercentage: DEFAULT_SLIPPAGE,), app/components/VaultControls/index.js (+ slippagePercentage: DEFAULT_SLIPPAGE,)
• Found constant ZAP_OUT in files app/containers/Zapper/actions.js (- ZAP_OUT,), app/containers/Zapper/actions.js (- type: ZAP_OUT,), app/containers/Zapper/constants.js (-export const ZAP_OUT = 'ZAP_OUT';), app/containers/Zapper/saga.js (- ZAP_OUT,), app/containers/Zapper/saga.js (- yield takeLatest(ZAP_OUT, zapOut);)
• Found constant ZAP_OUT_APPROVE in files app/containers/Zapper/actions.js (+ ZAP_OUT_APPROVE,), app/containers/Zapper/actions.js (+ type: ZAP_OUT_APPROVE,), app/containers/Zapper/constants.js (+export const ZAP_OUT_APPROVE = 'ZAP_OUT_APPROVE';), app/containers/Zapper/saga.js (+ ZAP_OUT_APPROVE,), app/containers/Zapper/saga.js (+ yield takeLatest(ZAP_OUT_APPROVE, zapOutApprove);)
• Found constant ZAP_OUT_WITHDRAW in files app/containers/Zapper/actions.js (+ ZAP_OUT_WITHDRAW,), app/containers/Zapper/actions.js (+ type: ZAP_OUT_WITHDRAW,), app/containers/Zapper/constants.js (+export const ZAP_OUT_WITHDRAW = 'ZAP_OUT_WITHDRAW';), app/containers/Zapper/saga.js (+ ZAP_OUT_WITHDRAW,), app/containers/Zapper/saga.js (+ yield takeLatest(ZAP_OUT_WITHDRAW, zapOutWithdraw);)
• Found constant ZAP_OUT_ALLOWANCE in files app/containers/Zapper/actions.js (+ ZAP_OUT_ALLOWANCE,), app/containers/Zapper/actions.js (+ type: ZAP_OUT_ALLOWANCE,), app/containers/Zapper/constants.js (+export const ZAP_OUT_ALLOWANCE = 'ZAP_OUT_ALLOWANCE';), app/containers/Zapper/reducer.js (+ ZAP_OUT_ALLOWANCE,), app/containers/Zapper/reducer.js (+ case ZAP_OUT_ALLOWANCE: {)
• Found constant ZAPPER_DATA_LOADED in files app/containers/Zapper/reducer.js (-import { ZAPPER_DATA_LOADED, ZAP_IN_ERROR, ZAP_OUT_ERROR } from './constants';), app/containers/Zapper/reducer.js (+ ZAPPER_DATA_LOADED,)
• Found constant ZAP_IN_ERROR in files app/containers/Zapper/reducer.js (-import { ZAPPER_DATA_LOADED, ZAP_IN_ERROR, ZAP_OUT_ERROR } from './constants';), app/containers/Zapper/reducer.js (+ ZAP_IN_ERROR,)
• Found constant ZAP_OUT_ERROR in files app/containers/Zapper/reducer.js (-import { ZAPPER_DATA_LOADED, ZAP_IN_ERROR, ZAP_OUT_ERROR } from './constants';), app/containers/Zapper/reducer.js (+ ZAP_OUT_ERROR,)
• Found keyword web3 in files app/components/VaultControls/index.js (- web3,), app/components/VaultControls/index.js (+ web3,), app/containers/Zapper/saga.js (+ const { web3, vaultContract, protocol } = action.payload;), app/containers/Zapper/saga.js (+ web3.eth.sendTransaction,), app/containers/Zapper/saga.js (- web3.eth.sendTransaction,)

[yearn-integrations]

Important changes detected (payment related code)

• Found constant DEFAULT_SLIPPAGE in files app/components/VaultControls/index.js (- slippagePercentage: DEFAULT_SLIPPAGE,), app/components/VaultControls/index.js (+ slippagePercentage: DEFAULT_SLIPPAGE,)
• Found constant ZAP_OUT in files app/containers/Zapper/actions.js (- ZAP_OUT,), app/containers/Zapper/actions.js (- type: ZAP_OUT,), app/containers/Zapper/constants.js (-export const ZAP_OUT = 'ZAP_OUT';), app/containers/Zapper/saga.js (- ZAP_OUT,), app/containers/Zapper/saga.js (- yield takeLatest(ZAP_OUT, zapOut);)
• Found constant ZAP_OUT_APPROVE in files app/containers/Zapper/actions.js (+ ZAP_OUT_APPROVE,), app/containers/Zapper/actions.js (+ type: ZAP_OUT_APPROVE,), app/containers/Zapper/constants.js (+export const ZAP_OUT_APPROVE = 'ZAP_OUT_APPROVE';), app/containers/Zapper/saga.js (+ ZAP_OUT_APPROVE,), app/containers/Zapper/saga.js (+ yield takeLatest(ZAP_OUT_APPROVE, zapOutApprove);)
• Found constant ZAP_OUT_WITHDRAW in files app/containers/Zapper/actions.js (+ ZAP_OUT_WITHDRAW,), app/containers/Zapper/actions.js (+ type: ZAP_OUT_WITHDRAW,), app/containers/Zapper/constants.js (+export const ZAP_OUT_WITHDRAW = 'ZAP_OUT_WITHDRAW';), app/containers/Zapper/saga.js (+ ZAP_OUT_WITHDRAW,), app/containers/Zapper/saga.js (+ yield takeLatest(ZAP_OUT_WITHDRAW, zapOutWithdraw);)
• Found constant ZAP_OUT_ALLOWANCE in files app/containers/Zapper/actions.js (+ ZAP_OUT_ALLOWANCE,), app/containers/Zapper/actions.js (+ type: ZAP_OUT_ALLOWANCE,), app/containers/Zapper/constants.js (+export const ZAP_OUT_ALLOWANCE = 'ZAP_OUT_ALLOWANCE';), app/containers/Zapper/reducer.js (+ ZAP_OUT_ALLOWANCE,), app/containers/Zapper/reducer.js (+ case ZAP_OUT_ALLOWANCE: {)
• Found constant ZAPPER_DATA_LOADED in files app/containers/Zapper/reducer.js (-import { ZAPPER_DATA_LOADED, ZAP_IN_ERROR, ZAP_OUT_ERROR } from './constants';), app/containers/Zapper/reducer.js (+ ZAPPER_DATA_LOADED,)
• Found constant ZAP_IN_ERROR in files app/containers/Zapper/reducer.js (-import { ZAPPER_DATA_LOADED, ZAP_IN_ERROR, ZAP_OUT_ERROR } from './constants';), app/containers/Zapper/reducer.js (+ ZAP_IN_ERROR,)
• Found constant ZAP_OUT_ERROR in files app/containers/Zapper/reducer.js (-import { ZAPPER_DATA_LOADED, ZAP_IN_ERROR, ZAP_OUT_ERROR } from './constants';), app/containers/Zapper/reducer.js (+ ZAP_OUT_ERROR,)
• Found keyword web3 in files app/components/VaultControls/index.js (- web3,), app/components/VaultControls/index.js (+ web3,), app/containers/Zapper/saga.js (+ const { web3, vaultContract, protocol } = action.payload;), app/containers/Zapper/saga.js (+ web3.eth.sendTransaction,), app/containers/Zapper/saga.js (- web3.eth.sendTransaction,)

[xgambitox]

Small detail: tooltip displays error as if wallet is not connected

[yearn-integrations]

Important changes detected (payment related code)

• Found constant DEFAULT_SLIPPAGE in files app/components/VaultControls/index.js (- slippagePercentage: DEFAULT_SLIPPAGE,), app/components/VaultControls/index.js (+ slippagePercentage: DEFAULT_SLIPPAGE,)
• Found constant ZAP_OUT in files app/containers/Zapper/actions.js (- ZAP_OUT,), app/containers/Zapper/actions.js (- type: ZAP_OUT,), app/containers/Zapper/constants.js (-export const ZAP_OUT = 'ZAP_OUT';), app/containers/Zapper/saga.js (- ZAP_OUT,), app/containers/Zapper/saga.js (- yield takeLatest(ZAP_OUT, zapOut);)
• Found constant ZAP_OUT_APPROVE in files app/containers/Zapper/actions.js (+ ZAP_OUT_APPROVE,), app/containers/Zapper/actions.js (+ type: ZAP_OUT_APPROVE,), app/containers/Zapper/constants.js (+export const ZAP_OUT_APPROVE = 'ZAP_OUT_APPROVE';), app/containers/Zapper/saga.js (+ ZAP_OUT_APPROVE,), app/containers/Zapper/saga.js (+ yield takeLatest(ZAP_OUT_APPROVE, zapOutApprove);)
• Found constant ZAP_OUT_WITHDRAW in files app/containers/Zapper/actions.js (+ ZAP_OUT_WITHDRAW,), app/containers/Zapper/actions.js (+ type: ZAP_OUT_WITHDRAW,), app/containers/Zapper/constants.js (+export const ZAP_OUT_WITHDRAW = 'ZAP_OUT_WITHDRAW';), app/containers/Zapper/saga.js (+ ZAP_OUT_WITHDRAW,), app/containers/Zapper/saga.js (+ yield takeLatest(ZAP_OUT_WITHDRAW, zapOutWithdraw);)
• Found constant ZAP_OUT_ALLOWANCE in files app/containers/Zapper/actions.js (+ ZAP_OUT_ALLOWANCE,), app/containers/Zapper/actions.js (+ type: ZAP_OUT_ALLOWANCE,), app/containers/Zapper/constants.js (+export const ZAP_OUT_ALLOWANCE = 'ZAP_OUT_ALLOWANCE';), app/containers/Zapper/reducer.js (+ ZAP_OUT_ALLOWANCE,), app/containers/Zapper/reducer.js (+ case ZAP_OUT_ALLOWANCE: {)
• Found constant ZAPPER_DATA_LOADED in files app/containers/Zapper/reducer.js (-import { ZAPPER_DATA_LOADED, ZAP_IN_ERROR, ZAP_OUT_ERROR } from './constants';), app/containers/Zapper/reducer.js (+ ZAPPER_DATA_LOADED,)
• Found constant ZAP_IN_ERROR in files app/containers/Zapper/reducer.js (-import { ZAPPER_DATA_LOADED, ZAP_IN_ERROR, ZAP_OUT_ERROR } from './constants';), app/containers/Zapper/reducer.js (+ ZAP_IN_ERROR,)
• Found constant ZAP_OUT_ERROR in files app/containers/Zapper/reducer.js (-import { ZAPPER_DATA_LOADED, ZAP_IN_ERROR, ZAP_OUT_ERROR } from './constants';), app/containers/Zapper/reducer.js (+ ZAP_OUT_ERROR,)
• Found keyword web3 in files app/components/VaultControls/index.js (- web3,), app/components/VaultControls/index.js (+ web3,), app/components/VaultControls/index.js (+ web3Account), app/components/VaultControls/index.js (+ withdrawDisabled || web3Account), app/containers/Zapper/saga.js (+ const { web3, vaultContract, protocol } = action.payload;), app/containers/Zapper/saga.js (+ web3.eth.sendTransaction,), app/containers/Zapper/saga.js (- web3.eth.sendTransaction,)

[patcito]

Small detail: tooltip displays error as if wallet is not connected

good catch, pushed a fix

[yearn-integrations]

Important changes detected (payment related code)

• Found constant ZAPPER_APIKEY in files app/components/VaultControls/index.js (+api_key=${ZAPPER_APIKEY}&sellTokenAddress=+), app/components/VaultControls/index.js (-api_key=${ZAPPER_APIKEY}&sellTokenAddress=+), app/components/VaultControls/index.js (-api_key=${ZAPPER_APIKEY}&sellTokenAddress=+)
• Found constant DEFAULT_SLIPPAGE in files app/components/VaultControls/index.js (- slippagePercentage: DEFAULT_SLIPPAGE,), app/components/VaultControls/index.js (+ slippagePercentage: DEFAULT_SLIPPAGE,)
• Found constant ZAP_OUT in files app/containers/Zapper/actions.js (- ZAP_OUT,), app/containers/Zapper/actions.js (- type: ZAP_OUT,), app/containers/Zapper/constants.js (-export const ZAP_OUT = 'ZAP_OUT';), app/containers/Zapper/saga.js (- ZAP_OUT,), app/containers/Zapper/saga.js (- yield takeLatest(ZAP_OUT, zapOut);)
• Found constant ZAP_OUT_APPROVE in files app/containers/Zapper/actions.js (+ ZAP_OUT_APPROVE,), app/containers/Zapper/actions.js (+ type: ZAP_OUT_APPROVE,), app/containers/Zapper/constants.js (+export const ZAP_OUT_APPROVE = 'ZAP_OUT_APPROVE';), app/containers/Zapper/saga.js (+ ZAP_OUT_APPROVE,), app/containers/Zapper/saga.js (+ yield takeLatest(ZAP_OUT_APPROVE, zapOutApprove);)
• Found constant ZAP_OUT_WITHDRAW in files app/containers/Zapper/actions.js (+ ZAP_OUT_WITHDRAW,), app/containers/Zapper/actions.js (+ type: ZAP_OUT_WITHDRAW,), app/containers/Zapper/constants.js (+export const ZAP_OUT_WITHDRAW = 'ZAP_OUT_WITHDRAW';), app/containers/Zapper/saga.js (+ ZAP_OUT_WITHDRAW,), app/containers/Zapper/saga.js (+ yield takeLatest(ZAP_OUT_WITHDRAW, zapOutWithdraw);)
• Found constant ZAP_OUT_ALLOWANCE in files app/containers/Zapper/actions.js (+ ZAP_OUT_ALLOWANCE,), app/containers/Zapper/actions.js (+ type: ZAP_OUT_ALLOWANCE,), app/containers/Zapper/constants.js (+export const ZAP_OUT_ALLOWANCE = 'ZAP_OUT_ALLOWANCE';), app/containers/Zapper/reducer.js (+ ZAP_OUT_ALLOWANCE,), app/containers/Zapper/reducer.js (+ case ZAP_OUT_ALLOWANCE: {)
• Found constant ZAPPER_DATA_LOADED in files app/containers/Zapper/reducer.js (-import { ZAPPER_DATA_LOADED, ZAP_IN_ERROR, ZAP_OUT_ERROR } from './constants';), app/containers/Zapper/reducer.js (+ ZAPPER_DATA_LOADED,)
• Found constant ZAP_IN_ERROR in files app/containers/Zapper/reducer.js (-import { ZAPPER_DATA_LOADED, ZAP_IN_ERROR, ZAP_OUT_ERROR } from './constants';), app/containers/Zapper/reducer.js (+ ZAP_IN_ERROR,)
• Found constant ZAP_OUT_ERROR in files app/containers/Zapper/reducer.js (-import { ZAPPER_DATA_LOADED, ZAP_IN_ERROR, ZAP_OUT_ERROR } from './constants';), app/containers/Zapper/reducer.js (+ ZAP_OUT_ERROR,)
• Found keyword web3 in files app/components/VaultControls/index.js (+ web3Account &&), app/components/VaultControls/index.js (+${vaultContract.address.toLowerCase()}&ownerAddress=${web3Account},), app/components/VaultControls/index.js (- web3,), app/components/VaultControls/index.js (+ web3,), app/components/VaultControls/index.js (- web3Account &&), app/components/VaultControls/index.js (-${vaultContract.address.toLowerCase()}&ownerAddress=${web3Account},), app/components/VaultControls/index.js (+ web3Account), app/components/VaultControls/index.js (- web3Account &&), app/components/VaultControls/index.js (-${vaultContract.address.toLowerCase()}&ownerAddress=${web3Account},), app/components/VaultControls/index.js (+ withdrawDisabled || web3Account), app/containers/Zapper/saga.js (+ const { web3, vaultContract, protocol } = action.payload;), app/containers/Zapper/saga.js (+ web3.eth.sendTransaction,), app/containers/Zapper/saga.js (- web3.eth.sendTransaction,)

[yearn-integrations]

Important changes detected (payment related code)

• Found constant ZAPPER_APIKEY in files app/components/VaultControls/index.js (+api_key=${ZAPPER_APIKEY}&sellTokenAddress=+), app/components/VaultControls/index.js (-api_key=${ZAPPER_APIKEY}&sellTokenAddress=+), app/components/VaultControls/index.js (+api_key=${ZAPPER_APIKEY}&sellTokenAddress=+)
• Found constant DEFAULT_SLIPPAGE in files app/components/VaultControls/index.js (- slippagePercentage: DEFAULT_SLIPPAGE,), app/components/VaultControls/index.js (+ slippagePercentage: DEFAULT_SLIPPAGE,)
• Found constant ZAP_OUT in files app/containers/Zapper/actions.js (- ZAP_OUT,), app/containers/Zapper/actions.js (- type: ZAP_OUT,), app/containers/Zapper/constants.js (-export const ZAP_OUT = 'ZAP_OUT';), app/containers/Zapper/saga.js (- ZAP_OUT,), app/containers/Zapper/saga.js (- yield takeLatest(ZAP_OUT, zapOut);)
• Found constant ZAP_OUT_APPROVE in files app/containers/Zapper/actions.js (+ ZAP_OUT_APPROVE,), app/containers/Zapper/actions.js (+ type: ZAP_OUT_APPROVE,), app/containers/Zapper/constants.js (+export const ZAP_OUT_APPROVE = 'ZAP_OUT_APPROVE';), app/containers/Zapper/saga.js (+ ZAP_OUT_APPROVE,), app/containers/Zapper/saga.js (+ yield takeLatest(ZAP_OUT_APPROVE, zapOutApprove);)
• Found constant ZAP_OUT_WITHDRAW in files app/containers/Zapper/actions.js (+ ZAP_OUT_WITHDRAW,), app/containers/Zapper/actions.js (+ type: ZAP_OUT_WITHDRAW,), app/containers/Zapper/constants.js (+export const ZAP_OUT_WITHDRAW = 'ZAP_OUT_WITHDRAW';), app/containers/Zapper/saga.js (+ ZAP_OUT_WITHDRAW,), app/containers/Zapper/saga.js (+ yield takeLatest(ZAP_OUT_WITHDRAW, zapOutWithdraw);)
• Found constant ZAP_OUT_ALLOWANCE in files app/containers/Zapper/actions.js (+ ZAP_OUT_ALLOWANCE,), app/containers/Zapper/actions.js (+ type: ZAP_OUT_ALLOWANCE,), app/containers/Zapper/constants.js (+export const ZAP_OUT_ALLOWANCE = 'ZAP_OUT_ALLOWANCE';), app/containers/Zapper/reducer.js (+ ZAP_OUT_ALLOWANCE,), app/containers/Zapper/reducer.js (+ case ZAP_OUT_ALLOWANCE: {)
• Found constant ZAPPER_DATA_LOADED in files app/containers/Zapper/reducer.js (-import { ZAPPER_DATA_LOADED, ZAP_IN_ERROR, ZAP_OUT_ERROR } from './constants';), app/containers/Zapper/reducer.js (+ ZAPPER_DATA_LOADED,)
• Found constant ZAP_IN_ERROR in files app/containers/Zapper/reducer.js (-import { ZAPPER_DATA_LOADED, ZAP_IN_ERROR, ZAP_OUT_ERROR } from './constants';), app/containers/Zapper/reducer.js (+ ZAP_IN_ERROR,)
• Found constant ZAP_OUT_ERROR in files app/containers/Zapper/reducer.js (-import { ZAPPER_DATA_LOADED, ZAP_IN_ERROR, ZAP_OUT_ERROR } from './constants';), app/containers/Zapper/reducer.js (+ ZAP_OUT_ERROR,)
• Found keyword web3 in files app/components/VaultControls/index.js (+ web3Account &&), app/components/VaultControls/index.js (+${vaultContract.address.toLowerCase()}&ownerAddress=${web3Account},), app/components/VaultControls/index.js (- web3,), app/components/VaultControls/index.js (+ web3,), app/components/VaultControls/index.js (+ web3Account), app/components/VaultControls/index.js (- web3Account &&), app/components/VaultControls/index.js (-${vaultContract.address.toLowerCase()}&ownerAddress=${web3Account},), app/components/VaultControls/index.js (+ web3Account &&), app/components/VaultControls/index.js (+${vaultContract.address.toLowerCase()}&ownerAddress=${web3Account},), app/components/VaultControls/index.js (+ withdrawDisabled || web3Account), app/containers/Zapper/saga.js (+ const { web3, vaultContract, protocol } = action.payload;), app/containers/Zapper/saga.js (+ web3.eth.sendTransaction,), app/containers/Zapper/saga.js (- web3.eth.sendTransaction,)

[ghost]

We have reverted to our previous logic to limit our risk of regression