search

yearn / yearn-protocol

Yearn smart contracts
https://yearn.finance
GNU Affero General Public License v3.0
441 stars 211 forks source link

First vault added to release a new apiVersion is always endorsed #96

Closed saltyfacu closed 3 years ago

saltyfacu commented 3 years ago

What's your issue about?

The vault that is used to create a new release using YRegistry.newRelease(0x...) is automatically endorsed and shown on Yearn's main site in the production tab.

Steps to reproduce Create a new release using YRegistry.newRelease(0x...) with any vault.

What is expected to happen. It's expected to create a new release and add the vault to the registry.

What actually happens. It creates a new release, adds the vault to the registry, and endorses it automatically.

Notes It's not always that the first vault of a new release is production-ready. So we need a way to create a new release, add a vault, and test it accordingly.

fubuloubu commented 3 years ago

Closing in favor of https://github.com/iearn-finance/yearn-vaults/issues/179