yearn / yearn-sdk

🦧 SDK for the yearn.finance platform. WIP
https://npm.im/@yfi/sdk
MIT License
53 stars 56 forks source link

feat: Add token unit tests #218

Closed karelianpie closed 2 years ago

karelianpie commented 2 years ago

Closes https://github.com/yearn/yearn-sdk/issues/213

karelianpie commented 2 years ago

Love the new approach @karelianpie just two final things:

🙇

  • Lets move those factories into a test-utils folder inside src so we know they are only used for testing

Done with https://github.com/yearn/yearn-sdk/pull/218/commits/3a8c1f6a20b20aefd31b2dc8d851ca993982625b

Sorry my bad, makes total sense, as it should be, refactored with https://github.com/yearn/yearn-sdk/pull/218/commits/4fb9b905c785ff4785730994937dab700d6cbc5f

karelianpie commented 2 years ago

@FiboApe I think it's best practice if the reviewer resolves the comments, so that it's easier for the author of the PR to see if something was not addressed. In all review comments I'll leave a link to the commit that addresses it, then it would be great if you could double check that my commit addresses your suggestion/comment and then resolve it so I know it's all good. What do you think?