Closed MahmoudHamdy02 closed 2 years ago
I have updated the error message, please let me know if it was committed correctly.
I have updated the error message, please let me know if it was committed correctly.
You've done more than changing the throw
to a console.error
, the changes you've introduced now belong in the other PR. Could you please remove them from this PR and here just have the convert if to a switch statement and instead of throwing having it console.error?
I had a bit of trouble with the previous commits but it should be good now, thanks and sorry for the trouble!
I had a bit of trouble with the previous commits but it should be good now, thanks and sorry for the trouble!
Please see my suggestion here https://github.com/yearn/yearn-sdk/pull/234/files#r819345715
I think you'd have to update the test as well, if you don't want to update the test maybe it's better to continue throwing and then with my PR we can change it to console.error
I have reverted it back to throwing the error, please let me know if the code is alright!
It's my first time using yarn, I installed it and ran yarn lint
and yarn lint --fix
, should hopefully be good now.
@MahmoudHamdy02 there are some tests failing, I think we need to change the syntax to
case 1:
case 1337: {
// ...
}
I've changed the syntax, please let me know if this works.
thanks @MahmoudHamdy02 🙂
Changed if statement to switch for issue #230.