yearn / yearn-sdk

🦧 SDK for the yearn.finance platform. WIP
https://npm.im/@yfi/sdk
MIT License
53 stars 56 forks source link

refactor: Return all supported tokens in available networks [WEB-1416] #249

Closed karelianpie closed 2 years ago

karelianpie commented 2 years ago

WEB-1416 (subtask of WEB-1008)

Refactors TokenInterface#supported() to return all supported tokens not only from Zapper but also from Vaults and Iron Bank for the current network. At the moment zapper only works for Ethereum, but we return the Vaults and Iron Bank tokens for the other networks i.e. Fantom and Arbitrum.

linear[bot] commented 2 years ago
WEB-1416 TokenInterface#supported() should return all supported tokens

1. sdk.tokens.supported() should return an array of all supported tokens from yearn products (Vaults, Labs, Zaps, other) for the current network.

github-actions[bot] commented 2 years ago

size-limit report 📦

Path Size
dist/sdk.cjs.production.min.js 41.45 KB (+0.39% 🔺)
dist/sdk.esm.js 42.25 KB (+0.58% 🔺)
xgambitox commented 2 years ago

@karelianpie We also should always do some manual testing locally following https://github.com/yearn/yearn-sdk#debug-the-website-with-a-local-copy-of-the-sdk , trying to test the functionality that was changed, to make sure the app does not break, since we want to be very sure all works as expected.

karelianpie commented 2 years ago

@karelianpie We also should always do some manual testing locally following https://github.com/yearn/yearn-sdk#debug-the-website-with-a-local-copy-of-the-sdk , trying to test the functionality that was changed, to make sure the app does not break, since we want to be very sure all works as expected.

Ah nice, will do that 👍