search

yearn / yearn-sdk

🦧 SDK for the yearn.finance platform. WIP
https://npm.im/@yfi/sdk
MIT License
53 stars 56 forks source link

fix: use lowercase address for zapper icon url #265

Closed jstashh closed 2 years ago

jstashh commented 2 years ago

Description

Use lowercased addresses when building icon urls (in the state they are fetched from zapper)

Related Issue

telegram-cloud-photo-size-1-5048613445632633402-y

e.g. https://assets.yearn.network/tokens/ethereum/0xc770eefad204b5180df6a14ee197d99d808ee52d.png https://assets.yearn.network/tokens/ethereum/0xc770EEfAd204B5180dF6a14Ee197D99d808ee52d.png

the checksummed link does not work

Motivation and Context

https://github.com/yearn/yearn-sdk/pull/249/files broke fetching the icons for some tokens

How Has This Been Tested?

By verifying that lowercased addresses in urls are able to be loaded correctly

github-actions[bot] commented 2 years ago

size-limit report 📦

Path Size
dist/sdk.cjs.production.min.js 43.54 KB (+0.01% 🔺)
dist/sdk.esm.js 43.79 KB (+0.01% 🔺)
karelianpie commented 2 years ago

Ahh this was my bad, sorry guys didn't realize that they would be different. Thanks for fixing it @jstashh 🙇

jstashh commented 2 years ago

@karelianpie don't worry 🙂 not sure why they're not using checksummed addresses anyway..