search

yearn / yearn-sdk

🦧 SDK for the yearn.finance platform. WIP
https://npm.im/@yfi/sdk
MIT License
53 stars 56 forks source link

fix: Eslint issues #272

Closed karelianpie closed 2 years ago

karelianpie commented 2 years ago

Description

I have noticed that tsdx https://github.com/jaredpalmer/tsdx/blob/master/src/createEslintConfig.ts was actually using old lint configs and also adding the "react-app" extension. I've removed that script from running our own lint and fixed all the issues that that brought (mostly trailing comma missing and parentheses around callback functions).

Motivation and Context

The eslint rules were being overwritten by https://github.com/jaredpalmer/tsdx/blob/master/src/createEslintConfig.ts

Testing

Also double checked that there are no unnecessary rules with

➜  yearn-sdk git:(fix/eslint) npx eslint-config-prettier dist/index.js
No rules that are unnecessary or conflict with Prettier were found.
github-actions[bot] commented 2 years ago

size-limit report 📦

Path Size
dist/sdk.cjs.production.min.js 44 KB (+0.09% 🔺)
dist/sdk.esm.js 44.37 KB (+0.05% 🔺)