search

yearn / yearn-vaults-v2-subgraph

26 stars 41 forks source link

AccountVaultPosition.balanceProfit returns inaccurate results when testing deposits #123

Open bsamuels453 opened 2 years ago

bsamuels453 commented 2 years ago

When performing a basic deposit() test, AccountVaultPosition.balanceProfit records the deposited amount as profit.

This value should be 0 as there has been no profit recognized by the vault in the conditions set up by the test.

0xkofee commented 2 years ago

seems this todo is gone. can we close?

AlexNi245 commented 2 years ago

I think this one is still not solved. The test this issue is about is commented out. You can find it at line 24 in this file