yearn / yearn-vaults-v2-subgraph

26 stars 41 forks source link

USDC Oracle returns 0 for usdcPricePerToken #135

Closed bsamuels453 closed 2 years ago

bsamuels453 commented 2 years ago

When performing the following query:

{
  vaults(where: {id:"0x5f18c75abdae578b483e5f43f12a39cf75b973a9"}){
    vaultDayData(orderBy:timestamp, orderDirection: asc, first:5){
      id
      timestamp
      pricePerShare
      totalReturnsGenerated
      totalReturnsGeneratedUSDC
      dayReturnsGenerated
      dayReturnsGeneratedUSDC
      tokenPriceUSDC
    }
  }
}

The USDC oracle returns "0" for the USDC-denominated value of the USDC token returns.

bsamuels453 commented 2 years ago

this is a limitation of the oracle and happens for all oracle queries before 12198044

0xkofee commented 2 years ago

so as long as the subgraph is synced, we should be good right?

bsamuels453 commented 2 years ago

yeah. tbh can probably close this issue since we dont really have a use case for data that old