search

yearn / yearn-vaults-v2-subgraph

26 stars 41 forks source link

Review Warnings in CI / CD Logs #139

Closed rareweasel closed 2 years ago

rareweasel commented 2 years ago

I saw some warning in the CI / CD that I think we should review.

Example: here

image
ghost commented 2 years ago

This has been fixed upstream in matchstick - https://github.com/LimeChain/matchstick/pull/225 To get rid of the warnings would need to update version mentioned in package.json - https://github.com/yearn/yearn-vaults-v2-subgraph/blob/77848be1374cf532521d00f113a2050f1271e28f/package.json#L23 Using newer version would also allow to use coverage tests.

bsamuels453 commented 2 years ago

@B3RX8OIPDHDT3 the matchstick version was pinned to 0.2.0 because their latest version at the time was breaking the test suite github action.

If you upgrade it and get it to work, would be happy to merge

ghost commented 2 years ago

Hey @bsamuels453, i've created a PR for it, you can see a GH action running succesfully here with no warnings in the output: https://github.com/B3RX8OIPDHDT3/yearn-vaults-v2-subgraph/runs/4920350646?check_suite_focus=true

Let me know if you have any questions/suggestions. :)