search

yearn / yearn-vaults-v2-subgraph

26 stars 41 forks source link

StrategyReportResult.duration measured in milliseconds instead of days #151

Open bsamuels453 opened 2 years ago

bsamuels453 commented 2 years ago

StrategyReportResult.duration is supposed to be measured in days, according to its documentation. It is currently measured in milliseconds. Either convert this field to measure the duration in days, or change the documentation to reflect its unit of measure.

Make sure upstream usages of this field in yearn-watch and yearn-sdk aren't impacted

0xbok commented 2 years ago

Which documentation are you referring to?

bsamuels453 commented 2 years ago

@0xbok https://github.com/yearn/yearn-vaults-v2-subgraph/blob/main/schema.graphql#L509-L510