search

yearn / yearn-vaults-v3

GNU Affero General Public License v3.0
96 stars 35 forks source link

Sweep functionality #122

Closed Schlagonia closed 1 year ago

Schlagonia commented 1 year ago

https://github.com/jmonteer/yearn-vaults-v3/blob/master/contracts/VaultV3.vy#L949-L959

  1. The erc20_safe_transfer uses ASSET.address as address paramater no matter what adress is passed to the funtion.
  2. V3 issues shares to itself that don't actually belong to itself while profit is unlocking. So I believe there should be a check of "assert token != self"