yearn / yearn-vaults-v3

GNU Affero General Public License v3.0
103 stars 37 forks source link

build: allow the factory gov to transfer #143

Closed Schlagonia closed 1 year ago

Schlagonia commented 1 year ago

Description

Changes: Allow for the governance of the Factory to be able to be changed.

Reasoning:

  1. Otherwise it would have to be deployed by the ychad multisig every time there is a new Vault version wanting to be released.

  2. Ideally in the future ownership over the fees should be given to a contract veYFI holders control, but if Gov is not transferrable for the older versions it would never be able to direct the fees for all older vaults.

  3. This factory should deploy every vault and last forever. Meaning if at any time the owner was compromised or then fees for every vault ever deployed using this factory can now be siphoned off to a incorrect address.

see https://github.com/flashfish0x/yearn-vaults-v3/pull/4

Fixes # (issue)

Checklist