yearn / yearn-vaults-v3

GNU Affero General Public License v3.0
107 stars 39 forks source link

rename amount in VaultV3.vy to asset to be consistent with ERC4626 standard #36

Closed anticlimactic closed 2 years ago

anticlimactic commented 2 years ago

see title:

even if we choose to implement erc4626 separately, having the vault call it "amount" and "shares" vs. erc4626 calling it "asset" and "shares" adds cognitive burden to people reading/reviewing the code.

i propose changing reference to amount to asset in the vault code.

jmonteer commented 2 years ago

I think this makes sense.

I will do it in #30

jmonteer commented 2 years ago

closed by #24 / #30