search

yearn / yearn-vaults-v3

GNU Affero General Public License v3.0
104 stars 37 forks source link

Permit should match compliant with eip-2612 #91

Closed pandadefi closed 2 years ago

pandadefi commented 2 years ago

permit follows the same abi as the one used on vault v2 <0.4.4.

On 0.4.4 permit follows eip-2612. This should be changed: https://github.com/jmonteer/yearn-vaults-v3/blob/master/contracts/VaultV3.vy#L930

jmonteer commented 2 years ago

@bufander can you tackle this?

bufander commented 2 years ago

Will do.

updated link: https://github.com/jmonteer/yearn-vaults-v3/blob/76a40585155d7d9e863651546fa90da0c7469f78/contracts/VaultV3.vy#L930