search

yearn / yearn-vaults

Yearn Vault smart contracts
https://yearn.finance/
GNU Affero General Public License v3.0
518 stars 317 forks source link

Depositor obtains BaseWrapper balance on pull deposit #533

Open skeletor-spaceman opened 2 years ago

skeletor-spaceman commented 2 years ago

afterBal should be changed to deposited https://github.com/yearn/yearn-vaults/blob/b3f33bd5a8ece52b6504d0c1cd9029fb639d6349/contracts/BaseWrapper.sol#L182

also, pull boolean should be immutable, not sure there is a usecase for both pull and non-pull deposits

westonnelson commented 2 years ago

I agree this is a bit confusing: perhaps using updatedBal or depositorBal might make this even more clear.