yearn / yearn-watch

Yearn Watch is a tool that provides vault and strategies data for management
https://yearn.watch
GNU General Public License v3.0
18 stars 24 forks source link

Bug: The strategies in the description seem to add yv to the token #118

Closed DarkGhost7 closed 1 year ago

DarkGhost7 commented 1 year ago

What happened 🆘

Yearn watch is appending yv to the strategies deposit token when it should not.

It should be looking for {{token}} from our ydeamon repo (https://github.com/yearn/ydaemon/blob/main/data/meta/strategies/1/ConvexReinvest.json#L4)

To Reproduce 🔂

Steps to reproduce the behavior: go to yearn.watch or next.yearn.watch and look at any strategy even non-curve ones.

More 🔎

What it should look like (vaults.yearn.finance) image What I see image

Majorfi commented 1 year ago

Pushed a fix to next branch, should be good in a few minutes! Thank you for the report!

DarkGhost7 commented 1 year ago

Thanks!

DarkGhost7 commented 1 year ago

This is also happening on the strategy details pages image https://yearn.watch/vault/0x490bD0886F221A5F79713D3E84404355A9293C50/0x000007252AB8d9120005d30aA15567Ea8de9a110

ai-slave commented 1 year ago

@DarkGhost7 how should it look like instead? Object has the name as "Curve ibCHF", is this right?

DarkGhost7 commented 1 year ago

Yes this should not show yv-token just token, so yes just Curve-ibCHF @ai-slave