FRP: for strategy name pull in the name in meta if exists

yearn / yearn.fi

https://yearn.fi

GNU General Public License v3.0

22 stars 48 forks source link

FRP: for strategy name pull in the name in meta if exists #94

Closed DarkGhost7 closed 1 year ago

DarkGhost7 commented 1 year ago

What is your proposal 🚀

I currently see this one the website ui

you can see that is using the smart contract name and not the name field in meta. For example this strategy should be called Idle Finance Reinvest not StrategyIdleV2 IdleUSDC v4 [Best yield]

What does this solve ? 🛠

Use nicer looking names for strategies, also if the meta file doesn't exist it can revert back to the strategy contract name.

karelianpie commented 1 year ago

If we go https://etherscan.io/address/0x66f7b6e7eb858075d6f2c5615f22659a1a20f6d6 we see that the name of the strategy is indeed "StrategyIdleV2 IdleUSDC v4 [Best yield]", the "Idle Finance Reinvest" https://github.com/yearn/ydaemon/blob/develop/data/meta/strategies/1/IdleReinvest.json is the name of the group which includes 0x66f7b6E7EB858075d6F2c5615F22659a1A20f6D6