search

yeatmanlab / AFQ-Browser

Browser-based visualization tools for AFQ results
BSD 3-Clause "New" or "Revised" License
33 stars 15 forks source link

Afqb reorg to save and load settings #147

Closed richford closed 7 years ago

richford commented 7 years ago

Supersedes #139 (see conversation there).

richford commented 7 years ago

@jyeatman @arokem @anotherjoshsmith. This is ready for testing. Let me know what you think.

You can read in the comments that I had to resort to a really unpleasant hack to get the axis zoom to refresh correctly. I just used a timeout function because I can't figure out the async dependency for the axis update. If this PR is accepted, we can open an issue to fix this in the future but I thought it'd be better to get this update out and ready for the paper rather than spend much more time on the optimal solution.

arokem commented 7 years ago

Thanks for doing this! It seems to be working well on my end. If someone else could give it a try, we can go ahead and merge this today/tomorrow.

jyeatman commented 7 years ago

I'll check it this evening

@arokem, once this is merged should we create a new release with pip?

On Sun, Jul 23, 2017 at 11:48 AM Ariel Rokem notifications@github.com wrote:

Thanks for doing this! It seems to be working well on my end. If someone else could give it a try, we can go ahead and merge this today/tomorrow.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yeatmanlab/AFQ-Browser/pull/147#issuecomment-317273470, or mute the thread https://github.com/notifications/unsubscribe-auth/ABsYyhMYeHffyrrP0vmY6_jGAQxXnYYqks5sQ5UugaJpZM4OgguT .

-- Sent from a mobile device. Please excuse typos

arokem commented 7 years ago

Yes. I can take care of that tomorrow or Tuesday at the latest.

On Sun, Jul 23, 2017 at 1:58 PM, Jason D. Yeatman notifications@github.com wrote:

I'll check it this evening

@arokem, once this is merged should we create a new release with pip?

On Sun, Jul 23, 2017 at 11:48 AM Ariel Rokem notifications@github.com wrote:

Thanks for doing this! It seems to be working well on my end. If someone else could give it a try, we can go ahead and merge this today/tomorrow.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yeatmanlab/AFQ-Browser/pull/ 147#issuecomment-317273470, or mute the thread https://github.com/notifications/unsubscribe- auth/ABsYyhMYeHffyrrP0vmY6_jGAQxXnYYqks5sQ5UugaJpZM4OgguT .

-- Sent from a mobile device. Please excuse typos

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yeatmanlab/AFQ-Browser/pull/147#issuecomment-317281651, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHPNiDoBFBkQofTStQMbziBVjWHoxj1ks5sQ7PrgaJpZM4OgguT .

jyeatman commented 7 years ago

Works well for me. One thing that isn't saved in the settings is whether it is set to std or stderr. I'll open an issue