search

yeatmanlab / AFQ-Browser

Browser-based visualization tools for AFQ results
BSD 3-Clause "New" or "Revised" License
33 stars 15 forks source link

Fix brush extent numbers #192

Closed richford closed 6 years ago

richford commented 6 years ago

Resolves #191

Remove redundant calls to afqb.plots.newBrush() and give all of the brushExt elements unique ids. Select using these ids instead of class.

richford commented 6 years ago

@arokem Does this resolve the issue on your end?

@jyeatman, @arokem: Long shot but does this resolve #190 for you?

arokem commented 6 years ago

It does resolve #191 on my end, and #190 also seems partially resolved as well -- I can see the tract profile plots, and brush extents appear on them. The node numbers don't always appear in the plots, until I start interacting with the brush extents. Is that related to this?

On Wed, Nov 15, 2017 at 9:56 PM, Adam Richie-Halford < notifications@github.com> wrote:

@arokem https://github.com/arokem Does this resolve the issue on your end?

@jyeatman https://github.com/jyeatman, @arokem https://github.com/arokem: Long shot but does this resolve #190 https://github.com/yeatmanlab/AFQ-Browser/issues/190 for you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yeatmanlab/AFQ-Browser/pull/192#issuecomment-344823839, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHPNqFCP1H6xttWTx3TlZRcOajZxRsxks5s285-gaJpZM4Qf_2L .

richford commented 6 years ago

Aha, I think I fixed it. Let me know if that works for you.

arokem commented 6 years ago

Hmm. I don't see how it would, but now it's broken again for me: I don't get the tract profiles appearing on the new page at all.

richford commented 6 years ago

I was getting frustrated with caching issues earlier. Sounds like they might be affecting you. My earlier advice about using incognito mode to avoid caching no longer works for me. So here's another workaround (thanks to @akeshavan for pointing this out to me):

  1. Open the developer tools (command + option + i on a mac).
  2. Go to the "Network" tab
  3. Select the "Disable cache" box at the top.

This should disable the cache whenever the developer tools or javascript console is open. So then refresh with the developer tools open.

Can you give that a try and see if the problem persists?

arokem commented 6 years ago

It persists :-(

richford commented 6 years ago

KHANNNNNNN!

richford commented 6 years ago

Okay, thanks for showing that error to me. That last commit should fix it.

arokem commented 6 years ago

It does indeed! Merging.

jyeatman commented 6 years ago

This works perfectly for me too!