search

yeatmanlab / pyAFQ

Automated Fiber Quantification ... in Python
http://yeatmanlab.github.io/pyAFQ/
BSD 2-Clause "Simplified" License
53 stars 34 forks source link

[ENH/FIX] Smarter file finding #1103

Closed 36000 closed 5 months ago

36000 commented 5 months ago

This solves two problems:

  1. Fix files being assigned to the wrong session
  2. Allow for subjects to have missing scalars
pep8speaks commented 5 months ago

Hello @36000! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 697:21: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

Line 226:29: E712 comparison to False should be 'if cond is not False:' or 'if cond:'

Comment last updated at 2024-02-06 02:28:51 UTC
arokem commented 4 months ago

Looks like maybe this broke the nightly PFT test?

https://github.com/yeatmanlab/pyAFQ/actions/runs/8036268264/job/21949771007

Strangely, I can't reproduce this locally, so it might be something subtle (and annoying).