search

yeatmanlab / pyAFQ

Automated Fiber Quantification ... in Python
http://yeatmanlab.github.io/pyAFQ/
BSD 2-Clause "Simplified" License
56 stars 34 forks source link

[REF] Refactor segmentation code into many files and pimms system #1132

Closed 36000 closed 4 months ago

36000 commented 5 months ago

This refactors the massive segmentation class into many files. It should make it a lot easier to change segmentation code in the future, ie, to make it so bundles can depend on the position of other bundles. It also makes recobundles into "just another" step in the pipeline, not as an entirely separate pipeline.

pep8speaks commented 5 months ago

Hello @36000! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-05-28 16:49:48 UTC
36000 commented 5 months ago

@arokem this is ready for review/merge

36000 commented 5 months ago

I think this is good to go, lets wait for #1124

36000 commented 4 months ago

@arokem i added some testing and modified the criteria system to not use pimms

36000 commented 4 months ago

@arokem this is ready for another round of review