yeatmanlab / roar-dashboard

A dashboard to administer ROAR assessments
https://roar.education
Other
4 stars 4 forks source link

Prevent ESC closing consent modal #526

Closed kellyel closed 5 months ago

kellyel commented 5 months ago

I found a neat un-documented prop to prevent the esc event from closing the modal.

github-actions[bot] commented 5 months ago

Visit the preview URL for this PR (updated for commit 8a82070):

https://roar-staging--pr526-enh-prevent-esc-gc3z2pfi.web.app

(expires Wed, 08 May 2024 19:59:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

ROAR
cypress[bot] commented 5 months ago

3 flaky tests on run #1335 ↗︎

0 34 0 0 Flakiness 3

Details:

Tests for PR 526 "Prevent ESC closing consent modal" from commit "8a820705668730...
Project: roar-dashboard-e2e Commit: 8a82070566
Status: Passed Duration: 27:44 💡
Started: May 1, 2024 8:03 PM Ended: May 1, 2024 8:31 PM
Flakiness  es-tests/playWord-ES.cy.js • 1 flaky test View Output
Test Artifacts
ROAR - Palabra Play Through > Plays Word Test Replay Screenshots
Flakiness  playSRE.cy.js • 1 flaky test View Output
Test Artifacts
ROAR - Sentence Play Through > Plays SRE Test Replay Screenshots
Flakiness  es-tests/playFluency-CALF-ES.cy.js • 1 flaky test View Output
Test Artifacts
Test playthrough of Fluency ARF ES as a participant > Fluency Playthrough Test Test Replay Screenshots

Review all test suite changes for PR #526 ↗︎