search

yeatmanlab / roar-dashboard

A dashboard to administer ROAR assessments
https://roar.education
Other
4 stars 4 forks source link

Add App Version to Run Doc #572

Closed ksmontville closed 5 months ago

ksmontville commented 5 months ago

This PR adds the app version number to the startAssessment() call in the Vue task component, which commands roar firekit to append the app version number to the user run doc.

github-actions[bot] commented 5 months ago

Visit the preview URL for this PR (updated for commit 5c86cea):

https://roar-staging--pr572-append-app-version-r-uhmum4gf.web.app

(expires Wed, 22 May 2024 20:44:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

cypress[bot] commented 5 months ago

8 failed and 2 flaky tests on run #1764 ↗︎

8 36 0 0 Flakiness 2

Details:

Tests for PR 572 "Add App Version to Run Doc" from commit "5c86ceac2d6fdc1e91df0...
Project: roar-dashboard-e2e Commit: 5c86ceac2d
Status: Failed Duration: 21:37 💡
Started: May 15, 2024 8:48 PM Ended: May 15, 2024 9:10 PM
Failed  playButtonGames.cy.js • 1 failed test View Output
Test Artifacts
Testing play through of vocab, cva, letter, and multichoice games as a participant > ROAR - Letter Play through Test Test Replay Screenshots
Failed  playPA.cy.js • 1 failed test View Output
Test Artifacts
Testing playthrough of ROAR-Phoneme as a participant > ROAR-Phoneme Playthrough Test Test Replay Screenshots
Failed  playSRE.cy.js • 1 failed test View Output
Test Artifacts
ROAR - Sentence Play Through > Plays SRE Test Replay Screenshots
Failed  playFluency-ARF.cy.js • 1 failed test View Output
Test Artifacts
Test playthrough of Fluency as a participant > Fluency Playthrough Test Test Replay Screenshots
Failed  playSWR.cy.js • 1 failed test View Output
Test Artifacts
ROAR - Word Play Through > Plays Word Test Replay Screenshots

The first 5 failed specs are shown, see all 8 specs in Cypress Cloud.

Flakiness  cypress/e2e/participant/default-tests/playButtonGames.cy.js • 2 flaky tests View Output
Test Artifacts
Testing play through of vocab, cva, letter, and multichoice games as a participant > ROAR - Written Vocabulary Play through Test Test Replay Screenshots
Testing play through of vocab, cva, letter, and multichoice games as a participant > ROAR - Morphology Play through Test Test Replay Screenshots

Review all test suite changes for PR #572 ↗︎

ksmontville commented 5 months ago

LGTM. I'll just echo @lucasxsong's comment about the console.log statement. Also, I think this PR is blocked until a new version of roar-firekit is deployed, right?

It can be merged but it won't have any effect on th run doc until the Firekit changes go in as well.