yeatmanlab / roar-dashboard

A dashboard to administer ROAR assessments
https://roar.education
Other
4 stars 4 forks source link

[LHT-328]: Sanitizing and validating user rows #609

Closed asengupta3 closed 1 month ago

asengupta3 commented 4 months ago

This code should:

  1. Remove any unnecessary columns that do not belong to allFields
  2. It should also throw errors if, multiple ids exist for the same user, no ids exist for the user and if there are duplicate ids across all users
github-actions[bot] commented 4 months ago

Visit the preview URL for this PR (updated for commit 03dccd0):

https://roar-staging--pr609-user-row-validations-gdb02h1h.web.app

(expires Fri, 14 Jun 2024 19:01:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

cypress[bot] commented 4 months ago

Passing run #2478 ↗︎

0 19 0 0 Flakiness 0

Details:

Tests for PR 609 "[LHT-328]: Sanitizing and validating user rows" from commit "0...
Project: roar-dashboard-e2e Commit: 03dccd0004
Status: Passed Duration: 01:52 💡
Started: Jun 7, 2024 7:01 PM Ended: Jun 7, 2024 7:03 PM

Review all test suite changes for PR #609 ↗︎

asengupta3 commented 1 month ago

Thanks @Emily-ejag for flagging this. This has been in a limbo for a while. @Zio-4 should we close this out and then deal with it in the fork or open a new ticket?

Zio-4 commented 1 month ago

Yes. Closing this since it's no longer relevant.