yeatmanlab / roar-dashboard

A dashboard to administer ROAR assessments
https://roar.education
Other
4 stars 4 forks source link

Fix: Blank Screen #645

Closed kellyel closed 4 months ago

kellyel commented 4 months ago

Proposed changes

I believe this will fix the issue of the games tabs not appearing after each game. Fixes: https://github.com/yeatmanlab/roar/issues/281

Types of changes

What types of changes does this pull request introduce?

Checklist

Justification of missing checklist items

Further comments

I understand that this change was originally made to decrease the package size of the app. However I feel that in this case, it is better to reverse the change to prevent this issue from occurring.

My theory as to what is happening is as follows. Those two components are being imported on the onMounted hook. Vue tries to reuse components whenever possible, thus will not call the onMounted hook in every case [1]. There seem to be some cases where when the user navigates back to a page, the onMounted hook is not fired. This is supported by the fact that in all cases we have evidence of, those two components are the only ones missing with no other apparent errors.

github-actions[bot] commented 4 months ago

Visit the preview URL for this PR (updated for commit ebd8fe4):

https://roar-staging--pr645-fix-blank-screen-apgbolsk.web.app

(expires Thu, 13 Jun 2024 16:19:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

ROAR
cypress[bot] commented 4 months ago

Passing run #2373 ↗︎

0 26 0 0 Flakiness 0

Details:

Tests for PR 645 "Fix: Blank Screen " from commit "ebd8fe4b985f8e312b794376398f2...
Project: roar-dashboard-e2e Commit: ebd8fe4b98
Status: Passed Duration: 06:20 💡
Started: Jun 6, 2024 4:50 PM Ended: Jun 6, 2024 4:57 PM

Review all test suite changes for PR #645 ↗︎

sentry-io[bot] commented 4 months ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎