Refreshing buttons css - Githubissues

Emily-ejag commented 4 months ago

Proposed changes

Delete the scss and css files for buttons which were overwriting Prime Flex / Prime Vue. Make the current buttons as similar as possible using in-line Prime Flex.

Types of changes

What types of changes does this pull request introduce?

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
[ ] Documentation Update
[ ] Tests (new or updated tests)
[x] Style (changes to code styling)
[ ] CI (continuous integration changes)
[x] Repository Maintenance
[ ] Other (please describe below)

Checklist

[x] I have read the guidelines for contributing.
[x] The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
[x] Linting checks pass with my changes.
[x] Any existing unit tests pass with my changes.
[x] Any existing end-to-end tests pass with my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
[ ] I have added JSDoc comments as appropriate.
[ ] I have added the necessary documentation to the roar-docs repository.
[ ] I have shared this PR on the roar-pr-reviews channel (if I have access)
[ ] I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

github-actions[bot] commented 4 months ago

Visit the preview URL for this PR (updated for commit 48e1a0d):

https://roar-staging--pr652-fix-deleting-button-k2lhq1f2.web.app

_{(expires Tue, 25 Jun 2024 00:21:48 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460}

cypress[bot] commented 4 months ago

Passing run #2693 ↗︎

0

26

0

Details:

Tests for PR 652 "Refreshing buttons css" from commit "48e1a0d0d1a108b9ef3dd4363...
Project: roar-dashboard-e2e	Commit: `48e1a0d0d1`
Status: Passed	Duration: 03:55 💡
Started: Jun 18, 2024 12:20 AM	Ended: Jun 18, 2024 12:24 AM

Review all test suite changes for PR #652 ↗︎

Emily-ejag commented 4 months ago

Yay! The new buttons look good. I've attached a few comments below.

I think these buttons should have no background. The score/progress report buttons were previously slightly grey on hover. Could we retain that behavior?

I think the logout button should be a text button (I've attached another screenshot of the button on roar.education for reference).