Move core assessments and visually separate tasks in score report

Emily-ejag commented 4 months ago

Proposed changes

On the Score Report move "Word, Sentence, and Phoneme" first, then gray out cell that belong to the other task because those are not validated.

On Progress Report only move the validated tasks first.

What types of changes does this pull request introduce?

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
[ ] Documentation Update
[ ] Tests (new or updated tests)
[x] Style (changes to code styling)
[ ] CI (continuous integration changes)
[ ] Repository Maintenance
[ ] Other (please describe below)

[x] I have read the guidelines for contributing.
[x] The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
[x] Linting checks pass with my changes.
[x] Any existing unit tests pass with my changes.
[x] Any existing end-to-end tests pass with my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
[ ] I have added JSDoc comments as appropriate.
[ ] I have added the necessary documentation to the roar-docs repository.
[x] I have shared this PR on the roar-pr-reviews channel (if I have access)
[ ] I have linked relevant issues (if any)

github-actions[bot] commented 4 months ago

Visit the preview URL for this PR (updated for commit 0363f93):

_{(expires Wed, 19 Jun 2024 23:10:09 GMT)}

_{Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460}

cypress[bot] commented 4 months ago

0

26

0

1

Details:

Tests for PR 656 "Move core assessments and visually separate tasks in score rep...
Project: roar-dashboard-e2e	Commit: `0363f93d47`
Status: Passed	Duration: 03:41 💡
Started: Jun 12, 2024 11:09 PM	Ended: Jun 12, 2024 11:13 PM

cypress/e2e/partner-admin/default-tests/testProgressReportFiltering.spec.cy.js • 1 flaky test

View Output

Test		Artifacts
The partner admin can view progress reports for a given administration and a not applicable filter returns an empty message > Selects an administration, views its score report, then accesses the column filter to filter by a non-returnable filter		`Test Replay` `Screenshots`

sentry-io[bot] commented 3 months ago

This pull request was deployed and Sentry observed the following issues:

‼️ TypeError: Cannot read properties of undefined (reading 'includes') progressReportColumns(src/pages/ProgressReport) View Issue

_{Did you find this useful? React with a 👍 or 👎}