Edit Users - Githubissues

kellyel commented 4 months ago

Proposed changes

Adds a modal to the list-users table to allow editing of users. This PR implements a modal to allow certain attributes to be edited by admins.

What types of changes does this pull request introduce?

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
[ ] Documentation Update
[ ] Tests (new or updated tests)
[ ] Style (changes to code styling)
[ ] CI (continuous integration changes)
[ ] Repository Maintenance
[ ] Other (please describe below)

[x] I have read the guidelines for contributing.
[x] The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
[x] Linting checks pass with my changes.
[x] Any existing unit tests pass with my changes.
[x] Any existing end-to-end tests pass with my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
[x] I have added JSDoc comments as appropriate.
[x] I have added the necessary documentation to the roar-docs repository.
[x] I have shared this PR on the roar-pr-reviews channel (if I have access)
[x] I have linked relevant issues (if any)

TODO Item!

github-actions[bot] commented 4 months ago

Visit the preview URL for this PR (updated for commit eaf7438):

_{(expires Wed, 26 Jun 2024 22:16:40 GMT)}

_{Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460}

cypress[bot] commented 4 months ago

8

18

0

Details:

Tests for PR 669 "Edit Users" from commit "eaf74380a1e58f65f86f0def66d7beb5efbe9...
Project: roar-dashboard-e2e	Commit: `eaf74380a1`
Status: Failed	Duration: 06:22 💡
Started: Jun 19, 2024 10:15 PM	Ended: Jun 19, 2024 10:22 PM

testScoreReportFiltering.cy.js • 4 failed tests

View Output

Test		Artifacts
The partner admin can view score reports for a given administration and filter by support level > Selects an administration, views its score report, then accesses the column filter to filter by support level		`Test Replay` `Screenshots`
The partner admin can view score reports for a given administration filter by school, grade, and progress status: completed > Selects an administration, views its score report, then accesses the column filter to filter by school, grade, and completed		`Test Replay` `Screenshots`
The partner admin can view score reports for a given administration and filter by Assessed > Selects an administration, views its score report, then accesses the column filter to filter by assessed		`Test Replay` `Screenshots`
The partner admin can view score reports for a given administration and a not applicable filter returns an empty message > Selects an administration, views its score report, then accesses the column filter to filter by a non-returnable filter		`Test Replay` `Screenshots`

testProgressReportFiltering.spec.cy.js • 4 failed tests

View Output

Test		Artifacts
The partner admin can view progress reports for a given administration and filter by school. > Selects an administration and views its score report, then accesses the filter bar to filter by school.		`Test Replay` `Screenshots`
The partner admin can view progress reports for a given administration and filter by progress status > Selects an administration, views its score report, then accesses the column filter to filter by progress status		`Test Replay` `Screenshots`
The partner admin can view progress reports for a given administration and filter by grade and progress status > Selects an administration, views its score report, then accesses the column filter to filter by grade and support level		`Test Replay` `Screenshots`
The partner admin can view progress reports for a given administration and a not applicable filter returns an empty message > Selects an administration, views its score report, then accesses the column filter to filter by a non-returnable filter		`Test Replay` `Screenshots`